Skip to content

Remove unused parameter for clarity in example #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samtstern merged 1 commit into from
Mar 20, 2020
Merged

Remove unused parameter for clarity in example #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions firestore/main/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,11 +1019,11 @@ function deleteCollection(db, collectionPath, batchSize) {
let query = collectionRef.orderBy('__name__').limit(batchSize);

return new Promise((resolve, reject) => {
deleteQueryBatch(db, query, batchSize, resolve, reject);
deleteQueryBatch(db, query, resolve, reject);
});
}

function deleteQueryBatch(db, query, batchSize, resolve, reject) {
function deleteQueryBatch(db, query, resolve, reject) {
query.get()
.then((snapshot) => {
// When there are no documents left, we are done
Expand All @@ -1049,7 +1049,7 @@ function deleteQueryBatch(db, query, batchSize, resolve, reject) {
// Recurse on the next process tick, to avoid
// exploding the stack.
process.nextTick(() => {
deleteQueryBatch(db, query, batchSize, resolve, reject);
deleteQueryBatch(db, query, resolve, reject);
});
})
.catch(reject);
Expand Down