Allow mismatched extensions when globbing rewrites.#198
Merged
Conversation
jwngr
pushed a commit
that referenced
this pull request
Dec 29, 2015
Allow mismatched extensions when globbing rewrites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Superstatic disallowed a mismatch of URL to rewritten static asset. This prevents a valid use case of a URL that is an HTML representation of a non-HTML file, e.g. GitHub file browsing.
This PR removes the extension check and always serves the matched file. In addition, added a test to ensure that the mime type is taken from the static asset, not the file extension.