Fix UTF-8 decoding error for multi-byte sequence at chunk boundary#13
Merged
Fix UTF-8 decoding error for multi-byte sequence at chunk boundary#13
Conversation
Author
|
@cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
tobias-fire
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTP chunked transfer encoding can split multi-byte UTF-8 characters (like box-drawing characters
─,┴) across chunk boundaries. The previous code decoded each chunk independently, which caused spurious "Invalid UTF-8 in response" errors on perfectly valid output — particularly with server-side formats likePSQLthat use box-drawing characters in table borders.This PR:
ChunkDecoderstruct that carries incomplete multi-byte sequences across chunk boundaries, only reporting an error when bytes are genuinely invalid