Skip to content

fix: hanging on engine start, if engine starting failed #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 24, 2022
Merged

fix: hanging on engine start, if engine starting failed #103

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8665fe
fix hanging on engine start, if engine starting failed
yuryfirebolt Jan 18, 2022
057e44f
Merge branch 'main' into start-engine-failed
yuryfirebolt Jan 20, 2022
cc700c0
Merge branch 'main' into start-engine-failed
yuryfirebolt Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/firebolt/model/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,11 +254,10 @@ def wait(seconds: int, error_message: str) -> None:
)

# wait for engine to start
while (
wait_for_startup
and engine.current_status_summary
!= EngineStatusSummary.ENGINE_STATUS_SUMMARY_RUNNING
):
while wait_for_startup and engine.current_status_summary not in {
EngineStatusSummary.ENGINE_STATUS_SUMMARY_RUNNING,
EngineStatusSummary.ENGINE_STATUS_SUMMARY_FAILED,
}:
wait(
seconds=5,
error_message=f"Could not start engine within {wait_timeout_seconds} seconds.", # noqa: E501
Expand Down