fix: databases.get_many function, add integration test for it #105
Conversation
stepansergeevitch
left a comment
stepansergeevitch
left a comment
There was a problem hiding this comment.
Looks good. Left some comment regarding tests
| # get all databases, with name_contains | ||
| databases = rm.databases.get_many(name_contains=database_name) | ||
| assert len(databases) > 0 | ||
| assert database_name in {db.name for db in databases} |
There was a problem hiding this comment.
Please also test passing attached_engine_name_eq and attached_engine_name_contains since we know it has engines.
Also, do you think we can test order_by?
We can just see how many databases there are from the first call, and if it's more that one we also try passing order_by
There was a problem hiding this comment.
Added tests for attached_engine_name_eq and attached_engine_name_contains. However, I would not do additional tests on order_by, since it looks likes we are re-implementing order_by functionality in the test
There was a problem hiding this comment.
We can still do some basic checks on order_by without re-implementing the functionality. e.g. checking that the parameter is propagated correctly and is added to the http request.
…olt-python-sdk into fix-databases-get-many
|
SonarCloud Quality Gate failed. |
No description provided.