feat: Fir 8425 implement multi statement funct #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
changed the title
ptiurin
reviewed
Jan 20, 2022
yuryfirebolt
suggested changes
Jan 20, 2022
stepansergeevitch
force-pushed
the
FIR-8425-implement-multi-statement-funct
branch
from
93097af to
fba7fda
Compare
yuryfirebolt
approved these changes
Jan 24, 2022
ptiurin
approved these changes
Jan 25, 2022
stepansergeevitch
force-pushed
the
FIR-8425-implement-multi-statement-funct
branch
from
fba7fda to
5d5d25a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
stepansergeevitch
deleted the
FIR-8425-implement-multi-statement-funct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented multi-statement queries functionality based on the design
https://docs.google.com/document/d/13O5jHFjnvRrNSvzBXNohYYz4ChI1jhi_7xyIwd1_7Xs/edit
nextsetmethod from PEP249 to be able to move to next result setcursor.stateto newCursorState.ERRORvalue if error occured during query execution. This allows to figure out if all queries have passed in case of multi-statement, and is more verbose in my opinionAdded unit and integration tests