fix: Added decimal.Decimal to _types.py. #111
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericf-firebolt
changed the title
Contributor
stepansergeevitch
left a comment
stepansergeevitch
left a comment
There was a problem hiding this comment.
Please also add unit tests
Contributor
Author
Decimal is a little weird/annoying in its inconsistency when converting numerical types vs strings, so I added two checks, one sending in a str, which returns a rather long string, and one sending in a numerical type—in this case a float—which returns a string with the same "significant digits" as the number that was input. |
stepansergeevitch
approved these changes
Jan 25, 2022
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated, added
decimal.Decimalto_types.pyto support dbt.