chore: Bump httpx to 0.21.3 #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
ptiurin
requested review from
eg-firebolt,
stepansergeevitch and
yuryfirebolt
stepansergeevitch
approved these changes
Jan 24, 2022
Contributor
Author
|
Holding this off until the next version of SDK so we can release previous features separately from this. This allows any clients that are not compatible with the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading
httpxto the latest version.pytest-httpxalso needed to be updated. API has changed slightly between those versions, most notablyto_responseis deprecated in favour ofhttpx.Responsealso pytest-httpx no longer accepts as equal<url>/?database=<db>and<url>?database=<db>.From quick research looks like slash first is generally accepted so I modified
query_urlmock to reflect that. This does not affect the actual execution (confirmed in integration testing) and is purely mock-related.This PR is a prerequisite to fixing the TCP timeout.