fix: Jupyter runtime #120
Merged
fix: Jupyter runtime #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
reviewed
Jan 27, 2022
stepansergeevitch
force-pushed
the
fix_jupyter
branch
from
0e38bcd to
caff871
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed jupyter notebook async issues, extended dbapi jupyter examples.
This fix also add's an ability to use sync connection and cursor inside an asyncio loop, which we didn't support previously.
The issue was that basically loops can't be nested in asyncio, and all jupyter code is run inside a loop. The workaround for this is to create a thread inside a running loop and use new loop there. One problem is that a single
httpx.AsyncClientshould use the same loop always, so connection needs to cache it, which is done by storingAsyncJobThread