feat(FIR-10741): Defaulting to cheapest engine type #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
changed the title
ptiurin
requested review from
eg-firebolt,
stepansergeevitch and
yuryfirebolt
yuryfirebolt
approved these changes
Jan 31, 2022
Contributor
yuryfirebolt
left a comment
yuryfirebolt
left a comment
There was a problem hiding this comment.
Looks good, just a few minor comments
stepansergeevitch
approved these changes
Jan 31, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid relying on hardcoded defaults of the engine type we want to dynamically select a default instance if a user does not specify one. A cheapest instance in terms of cost is a good idea for testing or when this field is accidentally left unset.