No longer hardcode provider #21
Conversation
|
I just checked out this branch, and it works creating engines in prod. |
|
|
||
| def get_provider_id(client: Client) -> str: | ||
| """Get the AWS provider_id.""" | ||
| response = client.get(url="/compute/v1/providers") |
There was a problem hiding this comment.
Add error handling here. Check that json doesn't contain "error"
There was a problem hiding this comment.
This should be handled by this hook: https://github.com/firebolt-analytics/firebolt-sdk/blob/189f34a8c4f1447282ceefd49fb7d547808dbd84/src/firebolt/client/hooks.py#L26
Looking at the docs: https://api.dev.firebolt.io/devDocs#operation/computeV1ListProviders
The hook parses out the "message" associated with an error. However, it currently does not examine the "error" field.
This kind of error handling needs to happen on pretty much all requests, so let's go over it in our Wednesday meeting to ensure we've got a good pattern, then I will apply it everywhere in a follow-on PR.
The API uses a different provider_id for each environment. Instead of hardcoding it, we will fetch it once per ResourceManager instance.
Slack thread: https://firebolt-analytics.slack.com/archives/C02DA1HHX40/p1633694589047900