Fir 8531 allow passing engine name rathe #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eg-firebolt
approved these changes
Oct 20, 2021
Contributor
eg-firebolt
left a comment
eg-firebolt
left a comment
There was a problem hiding this comment.
LGTM, left a handful of minor comments/nits
nice test coverage
| else: | ||
| engine_url = endpoint | ||
|
|
||
| assert engine_url is not None |
Contributor
Author
There was a problem hiding this comment.
This is just for mypy check, should never really fail.
I'll think of a another way
stepansergeevitch
deleted the
FIR-8531-allow-passing-engine-name-rathe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented connect function, which takes a list of connection parameters and returns database connection.
Allowed to pass engine_name rather than engine_url to connect function.
Engine url is resolved using resource manager
Added unit and integration tests
Updated examples.ipynb