fix: add custom loop for connection __del__ #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
changed the title
ptiurin
reviewed
Dec 6, 2021
|
Kudos, SonarCloud Quality Gate passed! |
ptiurin
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, I've finally managed to investigate the issue with
RuntimeWarning: coroutine 'BaseConnection._aclose' was never awaitedin tests.It seems like
connection.__del__function (which inside calls asynchronous_aclosein global event loop) sometimes gets called after the event loop is closed (because it's called by the garbage collector in background). To fix this, added a custom loop for connection to use it for closing. I assume this issue could happen in real environments too.