ci: Reuse code-check workflow in nightly, split python-app workflow #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
reviewed
Dec 13, 2021
Contributor
ptiurin
left a comment
ptiurin
left a comment
There was a problem hiding this comment.
I like the idea of splitting unit tests and code check out. Though maybe we should have a generic CI workflow that unifies those, for clarity. This way we'd have a single workflow with several checks on PR e.g.
CI/Code style -- SUCCESS
CI/Unit tests -- SUCCESS
CI/PR Title -- FAIL
Similar to nightly.yml
jobs:
code-style:
uses: .../code-style.yml
unit-tests:
uses: .../unit-tests.yml
pr-check:
uses: jef/conventional-commits-pr-action@v1.0.0. (since there's no point in moving it out)
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor ci improvements before documenting: