Skip to content

Conversation

@ericf-firebolt
Copy link
Contributor

to allow users of zsh to run integration tests locally.

@ericf-firebolt ericf-firebolt changed the title bug:Changed USERNAME env variable to USER_NAME fix:Changed USERNAME env variable to USER_NAME Dec 14, 2021
Copy link
Contributor

@stepansergeevitch stepansergeevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be aware that github action also require respective changes, specifically integration-tests.yml and nightly.yml.
Please make sure that github integration-tests action passes on this PR

Copy link
Contributor

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericf-firebolt ericf-firebolt merged commit 953ab30 into main Dec 16, 2021
@ericf-firebolt ericf-firebolt deleted the change-username-to-user_name branch December 16, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants