feat: RTD build added #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eg-firebolt
reviewed
Dec 14, 2021
.gitignore
Outdated
Comment on lines
285
to
288
| \#*\# | ||
|
|
||
| coverage-reports/* | ||
|
|
||
| # VS Code | ||
| .vscode/* | ||
| *.code-workspace | ||
| \#*\# |
Contributor
There was a problem hiding this comment.
@marknoack Do you know what happened here? Is this an intentional change?
Contributor
Author
There was a problem hiding this comment.
It's unintentional. No idea how this code snippet was added
eg-firebolt
approved these changes
Dec 15, 2021
eg-firebolt
reviewed
Dec 16, 2021
src/firebolt/service/types.py
Outdated
| # Underlying infrastructure is being recreated. | ||
| ''' Version of the PackDB is changing. | ||
| This is zero downtime operation that does not affect engine work.s | ||
| This status is reserved for future use (not used fow now).''' |
Contributor
There was a problem hiding this comment.
Indentation looks a little off here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.