fix: Fixed various typos I noticed in comments #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is called. Removed logic to retrieve account_id from manager; replaced with logic in client.
… to docstrings in asynch connections.py and connections.py.
…k for account_id.
…n.py. Fixed errors in account_id_callback in unit/conftest.py.
…unt name is used.
…mypy. Also, a couple of periods added in exception messages.
…and FireboltClientMixin to satisfy mypy.
…RL everywhere. Made account_name type to Optional[str]=None in _resolve_engine_url. Added account_name to conftests. Minor text corrections.
… no response error on missing account_name.
…/test_connection. Commented it out for now.
…nftest.py and client/client.py. Added async-property==0.2.1 back into setup.cfg.
stepansergeevitch
approved these changes
Jan 20, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.