Skip to content

Conversation

@zulinx86
Copy link
Contributor

Changes

Removes a message used for debug in the fingerprint dump command of the CPU template helper tool.

$ sudo cpu-template-helper fingerprint dump --config config.json
Some(0)

Note: This command will be backported into 1.4 release branch.

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • [ ] Any required documentation changes (code and docs) are included in this PR.
  • [ ] API changes follow the Runbook for Firecracker API changes.
  • [ ] User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • [ ] New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Removes a message used for debug in the fingerprint dump command of the
CPU template helper tool.

```
$ sudo cpu-template-helper fingerprint dump --config config.json
Some(0)
```

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
@zulinx86 zulinx86 self-assigned this Jun 13, 2023
@zulinx86 zulinx86 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jun 13, 2023
@zulinx86 zulinx86 merged commit b1ba5e6 into firecracker-microvm:main Jun 14, 2023
zulinx86 added a commit to zulinx86/firecracker that referenced this pull request Jun 14, 2023
Backports PR firecracker-microvm#3816.

Removes a message used for debug in the fingerprint dump command of the
CPU template helper tool.

```
$ sudo cpu-template-helper fingerprint dump --config config.json
Some(0)
```

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
@zulinx86 zulinx86 deleted the remove_debug_print branch June 14, 2023 08:26
zulinx86 added a commit to zulinx86/firecracker that referenced this pull request Jun 14, 2023
Backports PR firecracker-microvm#3816.

Removes a message used for debug in the fingerprint dump command of the
CPU template helper tool.

```
$ sudo cpu-template-helper fingerprint dump --config config.json
Some(0)
```

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86 added a commit that referenced this pull request Jun 14, 2023
Backports PR #3816.

Removes a message used for debug in the fingerprint dump command of the
CPU template helper tool.

```
$ sudo cpu-template-helper fingerprint dump --config config.json
Some(0)
```

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants