Backport PR #3813 and #3816 to v1.4 #3823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalyazin
previously approved these changes
Jun 14, 2023
roypat
previously approved these changes
Jun 14, 2023
The host information (kernel version and CPU info) always has to be displayed even when the test is aborted unexpectedly in the middle. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
Adds a missing dash "-" to the fingerprint comparison command of the CPU template helper tool. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
Regathers the fingerprint baseline files where some kernel versions, microcode versions and guest CPU configs are updated. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
Backports PR firecracker-microvm#3816. Removes a message used for debug in the fingerprint dump command of the CPU template helper tool. ``` $ sudo cpu-template-helper fingerprint dump --config config.json Some(0) ``` Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86
changed the title
roypat
approved these changes
Jun 14, 2023
kalyazin
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Backports PR #3813 and #3816 to v1.4
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in this PR.[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md.[ ] NewTODOs link to an issue.rust-vmm.