Fix devtool fix_perms command #4859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR firecracker-microvm#4856 extended the `fix_perms` devtool command to also fix permissions of the directory in which we put CI artifacts from `build_ci_artifacts` command. Since, we are now calling `fix_perms` from two different "workflows", i.e. build/test and CI artifacts building, it might be the case that some of the directories `fix_perms` is trying to fix permissions for, don't exist. Add `-f` flag to `chown` command of `fix_perms`, to avoid issues. Signed-off-by: Babis Chalios <bchalios@amazon.es>
bchalios
added
the
Status: Awaiting review
roypat
approved these changes
Oct 17, 2024
JackThomson2
approved these changes
Oct 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4859 +/- ##
=======================================
Coverage 84.05% 84.05%
=======================================
Files 251 251
Lines 28061 28061
=======================================
Hits 23588 23588
Misses 4473 4473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Manciukic
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
-fflag tochowncommand offix_perms, to avoid issues.Reason
PR #4856 extended the
fix_permsdevtool command to also fix permissions of the directory in which we put CI artifacts frombuild_ci_artifactscommand.Since we are now calling
fix_permsfrom two different "workflows", i.e. build/test and CI artifacts building, it might be the case that some of the directoriesfix_permsis trying to fix permissions for don't exist.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.