Skip to content

Conversation

@ShadowCurse
Copy link
Contributor

The instability is still there, so we revert #4865

@ShadowCurse ShadowCurse self-assigned this Oct 24, 2024
@ShadowCurse ShadowCurse added the Type: Fix Indicates a fix to existing code label Oct 24, 2024
@ShadowCurse ShadowCurse force-pushed the revert-4865-unpin_m6i branch from 491101b to 758fc18 Compare October 24, 2024 13:52
@ShadowCurse ShadowCurse force-pushed the revert-4865-unpin_m6i branch from 758fc18 to f7aaa67 Compare October 24, 2024 13:56
This reverts commit 800ec4c.

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
@ShadowCurse ShadowCurse force-pushed the revert-4865-unpin_m6i branch from f7aaa67 to 0838f1a Compare October 24, 2024 14:01
@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (cf89a8a) to head (0838f1a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4872   +/-   ##
=======================================
  Coverage   84.05%   84.05%           
=======================================
  Files         251      251           
  Lines       28096    28096           
=======================================
  Hits        23616    23616           
  Misses       4480     4480           
Flag Coverage Δ
5.10-c5n.metal ?
5.10-m5n.metal 84.66% <ø> (ø)
5.10-m6a.metal 83.96% <ø> (-0.01%) ⬇️
5.10-m6g.metal 80.73% <ø> (ø)
5.10-m6i.metal 84.65% <ø> (ø)
5.10-m7g.metal 80.73% <ø> (ø)
6.1-c5n.metal 84.67% <ø> (ø)
6.1-m5n.metal 84.66% <ø> (ø)
6.1-m6a.metal 83.96% <ø> (ø)
6.1-m6g.metal 80.73% <ø> (ø)
6.1-m6i.metal 84.65% <ø> (ø)
6.1-m7g.metal 80.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShadowCurse ShadowCurse added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Oct 24, 2024
@ShadowCurse ShadowCurse merged commit 579ff75 into main Oct 24, 2024
7 of 8 checks passed
@ShadowCurse ShadowCurse deleted the revert-4865-unpin_m6i branch October 24, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants