fix: fail physical counter test if phy counter reg isn't in snapshot #5038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
added
the
Status: Awaiting review
ShadowCurse
previously approved these changes
Feb 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5038 +/- ##
=======================================
Coverage 83.21% 83.21%
=======================================
Files 245 245
Lines 26626 26626
=======================================
Hits 22156 22156
Misses 4470 4470
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
reviewed
Feb 12, 2025
kalyazin
reviewed
Feb 12, 2025
roypat
force-pushed
the
fix-physical-counters
branch
from
0ef4915 to
d0e0573
Compare
Right now the test would pass on stock AL kernels, because without the commits from 6.4 [1] backported the CNTPCT_EL0 register won't even be included in the snapshot, and thus the assert is never reached. Fix this by failing the test if the register isnt found. [1]: https://lore.kernel.org/all/20230330174800.2677007-8-maz@kernel.org/ Fixes: 525e686 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
fix-physical-counters
branch
from
d0e0573 to
0bbf375
Compare
pb8o
approved these changes
Feb 13, 2025
kalyazin
approved these changes
Feb 13, 2025
Manciukic
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the test would pass on stock AL kernels, because without the commits from 6.4 backported the CNTPCT_EL0 register won't even be included in the snapshot, and thus the assert is never reached.
Fix this by failing the test if the register isnt found.
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.