Skip to content

do not fail balloon test if deflate_oom is false and guest crashes #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

do not fail balloon test if deflate_oom is false and guest crashes #5039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions tests/integration_tests/functional/test_balloon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,20 @@ def test_deflate_on_oom(uvm_plain_any, deflate_on_oom):
balloon_size_before = test_microvm.api.balloon_stats.get().json()["actual_mib"]
make_guest_dirty_memory(test_microvm.ssh, 128)

balloon_size_after = test_microvm.api.balloon_stats.get().json()["actual_mib"]
print(f"size before: {balloon_size_before} size after: {balloon_size_after}")
if deflate_on_oom:
assert balloon_size_after < balloon_size_before, "Balloon did not deflate"
try:
balloon_size_after = test_microvm.api.balloon_stats.get().json()["actual_mib"]
except ConnectionError:
assert (
not deflate_on_oom
), "Guest died even though it should have deflated balloon to alleviate memory pressure"

test_microvm.mark_killed()
else:
assert balloon_size_after >= balloon_size_before, "Balloon deflated"
print(f"size before: {balloon_size_before} size after: {balloon_size_after}")
if deflate_on_oom:
assert balloon_size_after < balloon_size_before, "Balloon did not deflate"
else:
assert balloon_size_after >= balloon_size_before, "Balloon deflated"


# pylint: disable=C0103
Expand Down