Fix audit v1.10 #5092
Merged
Fix audit v1.10 #5092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
added
the
Status: Awaiting review
bchalios
force-pushed
the
fix_audit_v1.10
branch
2 times, most recently
from
106567a to
7993a6e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.10 #5092 +/- ##
==================================================
Coverage 84.10% 84.10%
==================================================
Files 251 251
Lines 28080 28080
==================================================
Hits 23616 23616
Misses 4464 4464
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
While gdbstub moves away from paste as a dependency we will ignore this warning. (cherry picked from commit e7f6051) Signed-off-by: Jack Thomson <jackabt@amazon.com> Signed-off-by: Babis Chalios <bchalios@amazon.es>
`cargo audit` warns us about a security issue in `hashbrown` crate (RUSTSEC-2024-0402). We use this as a development dependency, so it does not affect Firecracker in production. As a result, we don't need to create a patch release. `cargo audit` also emits a warning for `kvm-ioctls` about RUSTSEC-2024-0428 which has to do with how newer Rust compilers handle downcasts mutable references to immutable pointers. Starting from 1.82.0 Rust compilers elide subsequent reads of this struct's fields post downcast. However, here we are using Rust 1.79.0, so this is not a problem. We update the dependency to appease `cargo audit`. Signed-off-by: Babis Chalios <bchalios@amazon.es>
bchalios
force-pushed
the
fix_audit_v1.10
branch
from
7993a6e to
9a19fc6
Compare
roypat
approved these changes
Mar 18, 2025
zulinx86
approved these changes
Mar 18, 2025
bchalios
merged commit 2392fe9
into
firecracker-microvm:firecracker-v1.10
5 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes for
cargo audit. We backport e7f6051 for ignoringpasteissue and also runcargo updateto updatehashbrowndev dependency.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.