Skip to content

Conversation

@zulinx86
Copy link
Contributor

@zulinx86 zulinx86 commented Dec 2, 2025

Changes / Reason

See the patches!

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • [N/A] I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • [N/A] I have mentioned all user-facing changes in CHANGELOG.md.
  • [N/A] If a specific issue led to this PR, this PR closes the issue.
  • [N/A] When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • [N/A] I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Since the cover letter does not include any code change, the git apply
command denies it by default. But the cover letter would be helpful for
readers since it gives many information (including background,
motivation, design decision, etc.). To allow to have the cover letter,
add --apply-empty option to the git apply command.

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
@zulinx86 zulinx86 force-pushed the kvm-clock branch 2 times, most recently from f636cbd to 29b307b Compare December 3, 2025 14:14
@zulinx86 zulinx86 assigned kalyazin and unassigned kalyazin Dec 3, 2025
@zulinx86 zulinx86 requested a review from kalyazin December 3, 2025 14:15
We used a very ad-hoc solution for kvm-clock. The new kernel patches
make gfn_to_pfn_cache (that kvm-clock is based on) work for guest_memfd
without the direct map.

Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
@zulinx86 zulinx86 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Dec 3, 2025
@ShadowCurse ShadowCurse merged commit 22b6680 into firecracker-microvm:feature/secret-hiding Dec 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants