feat(api/map): use new RPCs + set limit max to 100k#2065
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
| search: z.string().optional(), | ||
| sitemap: z.enum(["only", "include", "skip"]).default("include"), | ||
| limit: z.number().min(1).max(30000).default(5000), | ||
| limit: z.number().min(1).max(100000).default(5000), |
Contributor
There was a problem hiding this comment.
Schema allows limit up to 100k, but server caps results at 30k (MAX_MAP_LIMIT) causing silent truncation for requests >30k; align schema with backend cap or raise the backend cap to match.
Prompt for AI agents
Address the following comment on apps/api/src/controllers/v2/types.ts at line 624:
<comment>Schema allows limit up to 100k, but server caps results at 30k (MAX_MAP_LIMIT) causing silent truncation for requests >30k; align schema with backend cap or raise the backend cap to match.</comment>
<file context>
@@ -621,7 +621,7 @@ export const mapRequestSchema = crawlerOptions
search: z.string().optional(),
sitemap: z.enum(["only", "include", "skip"]).default("include"),
- limit: z.number().min(1).max(30000).default(5000),
+ limit: z.number().min(1).max(100000).default(5000),
timeout: z.number().positive().finite().optional(),
useMock: z.string().optional(),
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Switch map index queries to the new RPCs (query_index_at_split_level_with_meta_2 and query_index_at_domain_split_level_with_meta_2) and remove the newer-than filter to match their API. Raise the map request limit max from 30k to 100k to support larger crawls; aligns with ENG-3308.