Skip to content

(feat/dns) DNS Resolution errors should be a 200#2402

Merged
nickscamara merged 1 commit intomainfrom
nsc/dns-ok
Nov 15, 2025
Merged

(feat/dns) DNS Resolution errors should be a 200#2402
nickscamara merged 1 commit intomainfrom
nsc/dns-ok

Conversation

@nickscamara
Copy link
Copy Markdown
Member

@nickscamara nickscamara commented Nov 14, 2025

DNS Resolution errors should be a 200 with a success flag = false.


Summary by cubic

DNS resolution errors in the v1/v2 scrape endpoints now return 200 with success: false. We also bill 1 credit for these cases and set tracing status_code to 200.

  • New Features
    • v1/v2 scrape controllers return 200 with success:false, code, and error for SCRAPE_DNS_RESOLUTION_ERROR; spans record scrape.status_code=200.
    • Billing charges 1 credit on DNS resolution errors; worker forwards the error to billing.

Written for commit 9f6daa1. Summary will update automatically on new commits.

@nickscamara nickscamara requested a review from mogery as a code owner November 14, 2025 20:09
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@nickscamara nickscamara merged commit e0a0fdf into main Nov 15, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant