Add minAge parameter to scrape (ENG-4073)#2452
Merged
amplitudesxd merged 3 commits intomainfrom Nov 30, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 12 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/api/src/__tests__/snips/v2/scrape-cache.test.ts">
<violation number="1" location="apps/api/src/__tests__/snips/v2/scrape-cache.test.ts:145">
Use `scrapeRaw`/`scrapeWithFailure` instead of the success-only `scrape` helper when asserting error responses, otherwise the test throws a Jest assertion before it can inspect the 404 `SCRAPE_NO_CACHED_DATA` response.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
Member
Author
|
@cubic-dev-ai review this PR |
Contributor
@amplitudesxd I've started the AI code review. It'll take a few minutes to complete. |
mogery
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a minAge option to v2 scrape to require a minimum cache age and avoid re-scraping. If cached data is younger than minAge, the API returns 404 (SCRAPE_NO_CACHED_DATA) without falling back to other engines. Fulfills ENG-4073.
New Features
Migration
Written for commit 42f19c7. Summary will update automatically on new commits.