Skip to content

fix(api): don't bill where stealth proxy was unsupported#2484

Merged
amplitudesxd merged 1 commit intomainfrom
tom/eng-4090-mistakenly-charging-for-stealth-mode
Dec 3, 2025
Merged

fix(api): don't bill where stealth proxy was unsupported#2484
amplitudesxd merged 1 commit intomainfrom
tom/eng-4090-mistakenly-charging-for-stealth-mode

Conversation

@amplitudesxd
Copy link
Copy Markdown
Member

@amplitudesxd amplitudesxd commented Dec 3, 2025

Summary by cubic

Stop charging the stealth proxy fee when a site doesn’t support stealth mode. This fixes incorrect billing and aligns with Linear ENG-4090.

  • Bug Fixes
    • Track unsupportedFeatures in the scrape pipeline and return it with the document.
    • Skip the stealthProxy surcharge in calculateCreditsToBeBilled when stealthProxy is unsupported, even if proxyUsed is "stealth".
    • Pass unsupportedFeatures from scrapeURL to the worker so billing has the full context.

Written for commit b61a468. Summary will update automatically on new commits.

@amplitudesxd amplitudesxd requested a review from mogery as a code owner December 3, 2025 16:49
Copy link
Copy Markdown
Member

@mogery mogery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ty!

@amplitudesxd amplitudesxd merged commit db1a4e2 into main Dec 3, 2025
8 checks passed
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants