Skip to content

feat(api/scrapeURL): engpicker integ#2523

Merged
mogery merged 1 commit intomainfrom
mogery/eng-4152-implement-under-experimental-flag
Dec 8, 2025
Merged

feat(api/scrapeURL): engpicker integ#2523
mogery merged 1 commit intomainfrom
mogery/eng-4152-implement-under-experimental-flag

Conversation

@mogery
Copy link
Copy Markdown
Member

@mogery mogery commented Dec 8, 2025

under an experimental flag for now


Summary by cubic

Integrates Engpicker to adjust engine selection per domain behind an experimental flag, preferring tlsclient when safe. No default behavior change. Supports Linear ENG-4152.

  • New Features
    • Added __experimental_engpicker option (default false).
    • Introduced queryEngpickerVerdict(hostname) using index RPC with a 250ms timeout; returns TlsClientOk/ChromeCdpRequired/Uncertain/Unknown (Unknown on errors or write-only).
    • When verdict is TlsClientOk and no forceEngine is set, boosts tlsclient engines in the fallback sort to rank above CDP; otherwise keeps current ordering.
    • buildFallbackList is now async; scrape loop updated to await it.

Written for commit 5195a5d. Summary will update automatically on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@mogery mogery merged commit 7a253bb into main Dec 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant