feat: overview tile and network stats #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsai-jumptrading
requested review from
amliu-jumptrading and
asuzuki-jumptrading
atsai-jumptrading
force-pushed
the
atsai/overview_stats
branch
2 times, most recently
from
ba70e4e to
6500c9f
Compare
asuzuki-jumptrading
approved these changes
Dec 2, 2025
Collaborator
asuzuki-jumptrading
left a comment
asuzuki-jumptrading
left a comment
There was a problem hiding this comment.
Looks good! Just one Q
| } { | ||
| const bits = bytes * 8; | ||
| if (bits < 1_000) return { value: bits, unit: "b" }; | ||
| if (bits < 1_000) return { value: getRoundedBitsValue(bits), unit: "b" }; |
Collaborator
There was a problem hiding this comment.
Thanks for fixing this!
| > | ||
| {Array.from({ length: barCount }, (_, i) => { | ||
| const isHigh = i >= barCount * 0.95; | ||
| const isHigh = i >= barCount * 0.95 || i === barCount - 1; |
|
|
||
| function setTickMs(newTickMs?: number) { | ||
| if (newTickMs === undefined) return; | ||
| tickMs = newTickMs; |
Collaborator
There was a problem hiding this comment.
Doesn't this update for all users of this hook? Are we ok with that ok?
atsai-jumptrading
force-pushed
the
atsai/overview_stats
branch
2 times, most recently
from
fb5e29b to
1073120
Compare
| <Table.Cell className={styles.chart}> | ||
| <TileSparkLine | ||
| value={Math.min(1, emaValue / maxValue)} | ||
| background="#0000001F" |
Collaborator
There was a problem hiding this comment.
Should we put this in the colors.ts file since we're also using it in the SlotPerformance TileCard?
amliu-jumptrading
approved these changes
Dec 2, 2025
atsai-jumptrading
force-pushed
the
atsai/overview_stats
branch
from
1073120 to
0a2c87d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.