diag: check-engine metric by jherrera-jump · Pull Request #8996 · firedancer-io/firedancer

jherrera-jump · 2026-03-20T23:41:51Z

Copilot

Pull request overview

Adds a new “check-engine” style diagnostic metric to the diag tile, exposing per-component health status via generated metrics metadata and wiring the diag tile into the global metrics registry.

Changes:

Extend topology tile configuration to include diag.is_voting so health reporting can be vote-aware.
Introduce diag_healthy{health_component=...} gauge (Bundle/Vote/Replay/Turbine) and generate corresponding enum + metric metadata.
Implement health computation and reporting in fd_diag_tile.c, and hook diag metrics into the “all metrics” table and docs.

Reviewed changes

Copilot reviewed 5 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/disco/topo/fd_topo.h	Adds `diag` per-tile configuration (`is_voting`).
src/disco/metrics/metrics.xml	Defines `HealthComponent` enum and `diag.Healthy` gauge metric.
src/disco/metrics/generated/fd_metrics_enums.h	Generated enum constants for `health_component`.
src/disco/metrics/generated/fd_metrics_diag.h	Generated offsets/meta declarations for `diag_healthy`.
src/disco/metrics/generated/fd_metrics_diag.c	Generated `FD_METRICS_DIAG` metadata table.
src/disco/metrics/generated/fd_metrics_all.c	Registers `FD_METRICS_DIAG` for the diag tile kind.
src/disco/diag/fd_diag_tile.c	Implements component health evaluation and emits the new metrics.
src/app/firedancer/topology.c	Populates `tile->diag.is_voting` from config.
book/api/metrics-generated.md	Updates generated metrics documentation for `diag_healthy`.

Copilot

Pull request overview

Copilot reviewed 6 out of 12 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 6 out of 12 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 6 out of 11 changed files in this pull request and generated 3 comments.

mmcgee-jump · 2026-03-23T22:18:15Z

+</enum>
+
 <tile name="diag">
+    <gauge name="SystemHealth" enum="SystemHealthIndicator" summary="Per-component health indicator. 0 is unhealthy, 1 is healthy, 2 is unknown/not applicable" />


The cardinality here doesn't make sense. This implies SystemHealth is either in a "bundle", "vote", "replay", or "turbine" state.

You want 4 gauges, and the system health enum to be "Healthy", "Unhealthy". I don't know what "Unknown" represents but that should also be made very precise / clear, or removed.

Hmm ... actually I might be wrong here about the cardinality let me think about this more, but definitely Unknown is too vague

changing unknown to disabled

mmcgee-jump

.

Copilot

Pull request overview

Copilot reviewed 6 out of 11 changed files in this pull request and generated 7 comments.

mmcgee-jump

copilot comments seem mostly valid?

Copilot

Pull request overview

Copilot reviewed 7 out of 12 changed files in this pull request and generated no new comments.

jherrera-jump · 2026-03-25T21:50:12Z

Changed to scheme with 4 separate metrics. Will update book/guide in a future PR.

Copilot

Pull request overview

Copilot reviewed 7 out of 11 changed files in this pull request and generated 1 comment.

jherrera-jump requested a review from Copilot March 20, 2026 23:41

Copilot started reviewing on behalf of jherrera-jump March 20, 2026 23:42 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Comment thread src/disco/diag/fd_diag_tile.c

Comment thread src/disco/diag/fd_diag_tile.c Outdated

Comment thread src/disco/diag/fd_diag_tile.c

jherrera-jump force-pushed the jherrera/diag-check-engine branch from 84ba77d to 2d06814 Compare March 23, 2026 18:13

jherrera-jump requested a review from Copilot March 23, 2026 18:13

Copilot started reviewing on behalf of jherrera-jump March 23, 2026 18:13 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread src/disco/metrics/metrics.xml Outdated

Comment thread src/discof/tower/fd_tower_tile.c Outdated

Comment thread src/disco/metrics/metrics.xml Outdated

jherrera-jump force-pushed the jherrera/diag-check-engine branch from 2d06814 to 7356736 Compare March 23, 2026 19:36

jherrera-jump requested a review from Copilot March 23, 2026 19:36

Copilot started reviewing on behalf of jherrera-jump March 23, 2026 19:37 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread src/disco/diag/fd_diag_tile.c Outdated

jherrera-jump force-pushed the jherrera/diag-check-engine branch from 7356736 to 8350cd6 Compare March 23, 2026 19:59

jherrera-jump requested a review from Copilot March 23, 2026 20:00

Copilot started reviewing on behalf of jherrera-jump March 23, 2026 20:00 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Comment thread src/disco/diag/fd_diag_tile.c Outdated

Comment thread src/disco/diag/fd_diag_tile.c Outdated

Comment thread src/disco/diag/fd_diag_tile.c

jherrera-jump marked this pull request as ready for review March 23, 2026 20:54

jherrera-jump requested a review from mmcgee-jump March 23, 2026 20:55

jherrera-jump force-pushed the jherrera/diag-check-engine branch from 8350cd6 to 61a846e Compare March 23, 2026 21:26

mmcgee-jump reviewed Mar 23, 2026

View reviewed changes

mmcgee-jump requested changes Mar 23, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 24, 2026 16:59

jherrera-jump force-pushed the jherrera/diag-check-engine branch from 61a846e to d2b4154 Compare March 24, 2026 16:59

Copilot started reviewing on behalf of jherrera-jump March 24, 2026 16:59 View session

jherrera-jump requested a review from mmcgee-jump March 24, 2026 17:00

Copilot AI reviewed Mar 24, 2026

View reviewed changes

jherrera-jump force-pushed the jherrera/diag-check-engine branch from d2b4154 to 915cf51 Compare March 25, 2026 16:37

mmcgee-jump requested changes Mar 25, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 25, 2026 20:41

jherrera-jump force-pushed the jherrera/diag-check-engine branch from 915cf51 to 37d34f6 Compare March 25, 2026 20:41

Copilot started reviewing on behalf of jherrera-jump March 25, 2026 20:43 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

jherrera-jump requested a review from mmcgee-jump March 25, 2026 20:47

mmcgee-jump previously approved these changes Mar 25, 2026

View reviewed changes

jherrera-jump dismissed mmcgee-jump’s stale review via 3c4fb8d March 25, 2026 21:49

jherrera-jump force-pushed the jherrera/diag-check-engine branch from 37d34f6 to 3c4fb8d Compare March 25, 2026 21:49

jherrera-jump requested a review from mmcgee-jump March 25, 2026 21:50

drubin-fd reviewed Mar 25, 2026

View reviewed changes

Comment thread src/disco/metrics/metrics.xml Outdated

diag: check-engine metric

8e96271

Copilot AI review requested due to automatic review settings March 25, 2026 23:16

jherrera-jump force-pushed the jherrera/diag-check-engine branch from 3c4fb8d to 8e96271 Compare March 25, 2026 23:16

Copilot started reviewing on behalf of jherrera-jump March 25, 2026 23:16 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

Comment thread src/disco/diag/fd_diag_tile.c

mmcgee-jump approved these changes Mar 27, 2026

View reviewed changes

jherrera-jump merged commit 267b4a4 into firedancer-io:main Mar 27, 2026
22 checks passed

Conversation

jherrera-jump commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmcgee-jump Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

mmcgee-jump Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

jherrera-jump Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

mmcgee-jump left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mmcgee-jump left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

jherrera-jump commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jherrera-jump commented Mar 20, 2026 •

edited

Loading

jherrera-jump commented Mar 25, 2026 •

edited

Loading