restore: full snapshot resolve#9088
Merged
jvarela-jump merged 1 commit intojvarela/snapshot-incr-resolvefrom Apr 6, 2026
Merged
restore: full snapshot resolve#9088jvarela-jump merged 1 commit intojvarela/snapshot-incr-resolvefrom
jvarela-jump merged 1 commit intojvarela/snapshot-incr-resolvefrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the HTTP HEAD pre-resolve functionality to full snapshots, building upon PR #9050 which introduced the same mechanism for incremental snapshots. The goal is to validate the availability and freshness of snapshot data via HEAD requests before downloading, making the snapshot acquisition process more robust against stale gossip data.
Changes:
- Added
full_resolveandfull_resolve_peerfields to thefd_snapct_tilecontext structure for managing full snapshot HEAD pre-resolves - Extended memory allocation in
scratch_footprintandunprivileged_initto accommodate the new full snapshot resolver - Updated
rlimit_file_cntto account for the additional socket needed by the full snapshot HEAD resolver - Modified the
FD_SNAPCT_STATE_COLLECTING_PEERSstate in the snapshot acquisition state machine to perform HEAD pre-resolution for non-HTTPS peers before downloading full snapshots - Added comprehensive validation logic for full snapshots (checking for proper snapshot type and staleness) and error handling for timeouts and failures
- Added HEAD resolver cancellation in reset states for both full and incremental snapshots
- Initialized the new
full_resolveandfull_resolve_peerfields in both privileged and unprivileged initialization functions
81d1e77 to
814efdf
Compare
Performance Measurements ⏳
|
814efdf to
f2b362d
Compare
Performance Measurements ⏳
|
f2b362d to
d10888b
Compare
Performance Measurements ⏳
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends #9050 's
http headresolve to thefullsnapshot.Partially addresses #9091.