Cache bilinear form action on the Matrix#250
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
please make it explicit in the docs that this is the form without BCs
This saves us from having to go through compile_form repeatedly for the form action of the bilinear form of a matrix on a function, which is required for solving linear systems with boundary conditions.
Contributor
Author
|
@dham I think this is now correct. |
Member
There was a problem hiding this comment.
Does this prevent all of the preprocessing and other things from happening every time? That was, after all, the goal.
Contributor
Author
There was a problem hiding this comment.
It does, because the first time we call _assemble, we stash the kernels on the form, and since we're reusing the same form (just with the coefficients replace) these are getting picked up. I can make a not of that to make the code more understandable.
Replace the coefficient in the cached form action by the currently passed in Function. Otherwise we'd keep using the Function from the first call to _form_action.
Contributor
Author
|
Now with test. Is this good to go? |
Member
|
Yes. Go for it. |
kynan
added a commit
that referenced
this pull request
Apr 11, 2014
…ction-on-matrix Cache bilinear form action on the Matrix This saves us from having to go through compile_form repeatedly for the form action of the bilinear form of a matrix on a function, which is required for solving linear systems with boundary conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves us from having to go through compile_form repeatedly for the form
action of the bilinear form of a matrix on a function, which is required for
solving linear systems with boundary conditions.