Saddle point PC for WC-4DVar #4009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
…rakeproject/firedrake into JHopeCollins/fdv-saddle-pc
* Support MG + Cofunction in NLVP
--------- Co-authored-by: David Ham <David.Ham@imperial.ac.uk> Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
* Do not set different cache directories per job This should not be necessary as the disk caches are now safer in how they handle race conditions. Using a unified cache directory should improve performance.
* changed `interpolate` function * take action if passed a `Cofunction` * change inputs to V; comment about adjoint interpolation
* Improve install docs * Be really aggressive about purging the pip cache as this is a very common issue for users. * Mention that macOS needs Xcode. * Add venv instructions to dev install. --------- Co-authored-by: Josh Hope-Collins <joshua.hope-collins13@imperial.ac.uk> Co-authored-by: Leo Collins <leocollins511@gmail.com>
--------- Co-authored-by: tcalderon-space <littlemelody_is_cool@yahoo.com> Co-authored-by: Pablo Brubeck <brubeck@protonmail.com>
--------- Co-authored-by: Connor Ward <c.ward20@imperial.ac.uk>
* TSFC: physical_normals * Test 3D zany elements
* Use dependency groups for internal dependencies Dependency groups are a new feature of pyproject.tomls perfect for describing internal dependency requirements. See https://packaging.python.org/en/latest/specifications/dependency-groups/
* TensorFunctionSpace: support empty shape
* Update test durations to load balance CI * Fix make test_durations to be more robust * Actually use the durations file during a run
* Change refs to master to main * Fix notebook links
* use petsctools for the OptionsManager in adjoint test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the saddle point formulation for weak constraint 4DVar using
FourDVarReducedFunctional