Parametrise CrossMeshInterpolator tests#4556
Merged
Conversation
pbrubeck
changed the title
pbrubeck
force-pushed
the
pbrubeck/test-cross-mesh
branch
from
43beeca to
1716d14
Compare
pbrubeck
commented
Sep 11, 2025
pbrubeck
commented
Sep 11, 2025
pbrubeck
force-pushed
the
pbrubeck/test-cross-mesh
branch
from
d837646 to
c5a6a16
Compare
pbrubeck
force-pushed
the
pbrubeck/test-cross-mesh
branch
from
b08c537 to
903f351
Compare
pbrubeck
commented
Sep 25, 2025
pbrubeck
force-pushed
the
pbrubeck/test-cross-mesh
branch
from
a367d91 to
b95303b
Compare
connorjward
previously approved these changes
Sep 25, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Seems fine. Anything to clear this test file up is a good thing.
I also enjoy your use of mpi-pytest.
Contributor
Author
That was @leo-collins, unfortunately I had to squash all commits to resolve merge conflicts. |
connorjward
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description