Merged
Conversation
pbrubeck
reviewed
Jan 28, 2026
Contributor
|
@leo-collins for this sort of thing I think @pbrubeck should be the reviewer. |
pbrubeck
approved these changes
Jan 29, 2026
Contributor
pbrubeck
left a comment
pbrubeck
left a comment
There was a problem hiding this comment.
Makes sense, I'm happy if this makes the test pass. The comment above makes it very clear that it only applies to bilinear Form.
j-bowhay
pushed a commit
to j-bowhay/firedrake
that referenced
this pull request
Feb 24, 2026
connorjward
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero-form interpolation
interpolate(operand, dual_arg)was broken ifdual_argwas a one-form and not a Cofunction.