Accept pathlib.Path objects as filename in Mesh#4853
Merged
connorjward merged 5 commits intofiredrakeproject:mainfrom Feb 3, 2026
Merged
Accept pathlib.Path objects as filename in Mesh#4853connorjward merged 5 commits intofiredrakeproject:mainfrom
connorjward merged 5 commits intofiredrakeproject:mainfrom
Conversation
Contributor
Author
|
As mentioned in the Issue the test throws an error in the newest version of I implemented this with the docker image of firedrakeproject/firedrake this error was not thrown, as this version did not have the "problematic" line 13: |
connorjward
requested changes
Feb 2, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Thanks for taking this on!
…/firedrake into check-for-Path-objects-in-mesh
connorjward
approved these changes
Feb 3, 2026
j-bowhay
pushed a commit
to j-bowhay/firedrake
that referenced
this pull request
Feb 24, 2026
connorjward
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3424
This is done by adding a check if the filename passed to the Mesh class is of the
pathlib.Pathtype.Additionally the
test_load_mesh.pytest has be extended to test for passing such a filename to the mesh.