Avoid creating a function space when calculating bounding box coordinates#4900
Merged
Avoid creating a function space when calculating bounding box coordinates#4900
Conversation
connorjward
requested changes
Feb 18, 2026
leo-collins
force-pushed
the
leo/bounding-box-coords
branch
from
883e350 to
5062a59
Compare
dham
approved these changes
Feb 19, 2026
sghelichkhani
pushed a commit
to sghelichkhani/firedrake
that referenced
this pull request
Feb 21, 2026
…ates (firedrakeproject#4900) use numpy directly for non-extruded
j-bowhay
pushed a commit
to j-bowhay/firedrake
that referenced
this pull request
Feb 24, 2026
…ates (firedrakeproject#4900) use numpy directly for non-extruded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating the
VectorFunctionSpacewas taking a big chunk of the cell-location time. We can avoid doing this in the non-extruded case.