Optimisation in parent_mesh_embedding#4906
Merged
connorjward merged 6 commits intomainfrom Feb 23, 2026
Merged
Conversation
connorjward
reviewed
Feb 19, 2026
dham
previously approved these changes
Feb 19, 2026
leo-collins
force-pushed
the
leo/parent-mesh-embedding
branch
from
8549f64 to
3bbb78e
Compare
connorjward
requested changes
Feb 20, 2026
connorjward
approved these changes
Feb 20, 2026
j-bowhay
pushed a commit
to j-bowhay/firedrake
that referenced
this pull request
Feb 24, 2026
connorjward
pushed a commit
that referenced
this pull request
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, in order to get the mesh cell rank ownership on each process, we were interpolating a
Constant(parent_mesh.comm.rank)into DG0 Function. Building the function space and generating the code was very slow.We can just build
visible_rankson each process and do a halo exchange.