Skip to content

Fix dumpdir fixture#4922

Merged
connorjward merged 1 commit intoreleasefrom
connorjward/fix-dumpdir
Feb 26, 2026
Merged

Fix dumpdir fixture#4922
connorjward merged 1 commit intoreleasefrom
connorjward/fix-dumpdir

Conversation

@connorjward
Copy link
Copy Markdown
Contributor

Previously the dumpdir fixture would rely on the mesh fixture. This lead to some confusing behaviour where

$ pytest tests/firedrake/output/test_pvd_output.py::test_bad_cell --co

was giving the very confusing result of

collected 8 items                                                                                                     

<Dir firedrake>
  <Dir tests>
    <Dir firedrake>
      <Dir output>
        <Module test_pvd_output.py>
          <Function test_bad_cell[interval]>
          <Function test_bad_cell[square[tri]]>
          <Function test_bad_cell[square[quad]]>
          <Function test_bad_cell[box[tet]]>
          <Function test_bad_cell[box[quad x interval]]>
          <Function test_bad_cell[box[hex]]>
          <Function test_bad_cell[sphere[tri]]>
          <Function test_bad_cell[sphere[quad]]>

despite test_bad_cell not needing the mesh fixture.

Comment thread tests/firedrake/output/conftest.py
@connorjward connorjward merged commit 1d0fa18 into release Feb 26, 2026
7 checks passed
@connorjward connorjward deleted the connorjward/fix-dumpdir branch February 26, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants