Add CUDA configuration to firedrake-configure and github actions#4988
Merged
connorjward merged 8 commits intofiredrakeproject:mainfrom Apr 13, 2026
Merged
Conversation
dsroberts
force-pushed
the
dsroberts/firedrake-cuda-build
branch
from
4c9aefa to
f3a4bb6
Compare
connorjward
requested changes
Mar 25, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Looks pretty good. Thanks!
I am sad at how firedrake-configure is getting more confusing, but it's very hard to avoid and certainly not your job to fix.
connorjward
requested changes
Mar 26, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
I think this is very very close now.
Contributor
Author
|
Hi @connorjward. I think I've addressed all the review comments, can you let me know if there is anything I've missed? |
connorjward
approved these changes
Apr 13, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
This is great work. Thank you so much for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the build and CI component of #4953. It also contains the
skipnogpupytest marker. Tagged withmacOSto ensure that changes tofiredrake-configurehave not broken the macOS build.