bugfix: MixedCovariance.function_space property#5070
Merged
connorjward merged 2 commits intoMay 1, 2026
Conversation
connorjward
approved these changes
May 1, 2026
Member
Author
|
@connorjward any idea what is happening with the CI? https://github.com/firedrakeproject/firedrake/actions/runs/25183740560/job/73906739867?pr=5070 |
Contributor
|
I would guess that you should first merge release into your branch to make sure it's completely updated. |
Member
Author
|
I think it was up to date with |
pbrubeck
pushed a commit
that referenced
this pull request
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally
MixedCovariance.function_spacewas a property, but this wasn't consistent with the otherCovarianceOperatortypes wherefunction_spaceis a method. I missed this line when I fixed it.