Refactor firedrake configure#5073
Merged
Merged
Conversation
All logic is now gone. All possible configs are explicitly enumerated. This is needed because the previous approach was not extensible (e.g. supporting Ubuntu 24.04 and 26.04 together). This opens the door to having 'community' configurations and even externally provided configuration files.
…or-firedrake-configure
JHopeCollins
reviewed
May 5, 2026
JHopeCollins
reviewed
May 5, 2026
JHopeCollins
reviewed
May 5, 2026
JHopeCollins
reviewed
May 5, 2026
JHopeCollins
reviewed
May 5, 2026
JHopeCollins
reviewed
May 5, 2026
JHopeCollins
reviewed
May 6, 2026
JHopeCollins
reviewed
May 6, 2026
JHopeCollins
reviewed
May 6, 2026
JHopeCollins
reviewed
May 6, 2026
JHopeCollins
approved these changes
May 6, 2026
pbrubeck
pushed a commit
that referenced
this pull request
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All logic is now gone. All possible configs are explicitly enumerated.
This is needed because the previous approach was not extensible (e.g.
supporting Ubuntu 24.04 and 26.04 together).
This opens the door to having 'community' configurations and even
externally provided configuration files.