Fix for quadrature rule with mixed dimension macroelements#5074
Merged
Conversation
connorjward
previously approved these changes
May 1, 2026
pbrubeck
force-pushed
the
pbrubeck/macro-submesh
branch
from
017ed43 to
7a76f29
Compare
pbrubeck
force-pushed
the
pbrubeck/macro-submesh
branch
from
7a76f29 to
3da51a1
Compare
pbrubeck
added a commit
that referenced
this pull request
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Codim-1 submesh assembly with macroelements was failing to get the right cell to build the quadrature rule.