Adjoint + submesh#5081
Merged
Merged
Conversation
connorjward
requested changes
May 7, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Please add some tests
connorjward
requested changes
May 7, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Please add some tests
JHopeCollins
reviewed
May 7, 2026
JHopeCollins
reviewed
May 7, 2026
connorjward
previously requested changes
May 8, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
I think this is basically there subject to the final discussion about function_space()
JHopeCollins
previously requested changes
May 12, 2026
Member
JHopeCollins
left a comment
JHopeCollins
left a comment
There was a problem hiding this comment.
The implementation looks good to me, thanks for fixing this!
Just a small change needed to the tests so we check the TLM and Hessian models, then this is ready to go.
pbrubeck
reviewed
May 12, 2026
pbrubeck
reviewed
May 12, 2026
pbrubeck
reviewed
May 12, 2026
Contributor
Author
|
Firedrake functions in the real space are now treated as functions without calling |
JHopeCollins
approved these changes
May 14, 2026
Member
JHopeCollins
left a comment
JHopeCollins
left a comment
There was a problem hiding this comment.
LGTM, thanks @KarsKnook!
Contributor
|
Sorry to be a pain... but shouldn't this have gone into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make the adjoint compatible with
Submesh, both the mesh and submesh are added as dependencies to an adjoint block. This is accomplished by replacingufl_domainandas_domainwithextract_domainsin the appropriate files.Perhaps this implementation is too naive and not all meshes need to be added as dependencies?
Does this account for all adjoint + submesh cases?
To do:
Disclaimer:
ChatGPT came up with the initial implementation which was restructured by me