More indexed vfs #963
Merged
More indexed vfs #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exercises a corner case where we should kill both components but only end up killing one.
If a boundary node appears in one BC object that sets all the components, but another that only sets one component, we will set some high bits. Later, in PyOP2, we use the presence of high bits to decide which components to kill. Therefore, if any of the BC objects are going to set a component, we should "unroll" the full BCs to set all the high bits so that we kill all the components. Fixes #920, hopefully for good.
wence-
added a commit
that referenced
this pull request
Dec 12, 2016
* more-indexed-vfs: More careful fix of component bcs Add test of component bcs where full bc overlaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More careful attempt to fix #920. See 00d9066 for explanation.