Simple fix for pyop3 #305
Merged
Simple fix for pyop3 #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
force-pushed
the
connorjward/pyop3
branch
from
487033d to
5456c12
Compare
connorjward
force-pushed
the
connorjward/pyop3
branch
from
5456c12 to
bc66b5f
Compare
JDBetteridge
requested changes
Oct 21, 2024
Co-authored-by: Jack Betteridge <43041811+JDBetteridge@users.noreply.github.com>
JDBetteridge
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small API change lets me use
default_entrypointlater on when I am generating code (https://github.com/inducer/loopy/blob/db136129dc53b48a63cc5e5eb597a77540093132/loopy/kernel/creation.py#L2618).Firedrake CI run: firedrakeproject/firedrake#3811
I really doubt this will cause any issues but I cannot be sure.