Skip to content

Prepared basic test units and added timestamps for post events#9

Merged
lahovniktadej merged 3 commits into
firefly-cpp:mainfrom
AyanDas348:main
May 22, 2023
Merged

Prepared basic test units and added timestamps for post events#9
lahovniktadej merged 3 commits into
firefly-cpp:mainfrom
AyanDas348:main

Conversation

@AyanDas348
Copy link
Copy Markdown
Contributor

Here's an overview of the changes:

  • Added unit tests to validate the behavior of the API endpoints.
  • Implemented the collection of timestamps using the datetime module.
  • Updated the API logic to store the timestamps alongside the data.

Please review the changes and let me know if you have any feedback or suggestions for improvement. I'm open to any discussions or modifications to make the code even better.

@firefly-cpp firefly-cpp requested a review from lahovniktadej May 22, 2023 06:54
@firefly-cpp
Copy link
Copy Markdown
Owner

Comment: please move mock to dev dependencies

Copy link
Copy Markdown
Collaborator

@lahovniktadej lahovniktadej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @AyanDas348. The GitHub workflow most likely fails due to the non-existing data directory (which will be fixed in upcoming versions).

@lahovniktadej lahovniktadej merged commit 3b5006e into firefly-cpp:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants