[PASO 2.3] Add NavigationService, BreadcrumbService and provideNavigation#17
Merged
Merged
Conversation
…t tests Create navigation module with generic recursive NavItem architecture: - NavItem with optional route and recursive children (no NavGroup) - NavigationService: configure, registerItem, unregisterItem, navItems with recursive permission filtering, activeRoute via toSignal() - BreadcrumbService: breadcrumbs computed from ActivatedRoute data - 20 unit tests (15 NavigationService + 5 BreadcrumbService)
Create provider factory following provideMasterData pattern: - InjectionToken for NavigationConfig injection - Synchronous APP_INITIALIZER that calls configure() - 3 unit tests (valid providers, init configures service, empty items)
…0.3.0 - Create navigation/index.ts barrel with all public exports - Re-export navigation module from root src/index.ts - Version bump 0.2.0 → 0.3.0 (minor: new module)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NavigationServicewith generic recursiveNavItemarchitecture —configure(),registerItem(),unregisterItem(),navItems(computed with recursive permission filtering),activeRoute(viatoSignal())BreadcrumbService— breadcrumbs computed fromActivatedRoutedata viatoSignal()provideNavigation(config)provider factory with synchronousAPP_INITIALIZER@fireflyframework/coreto 0.3.0Architecture decisions
NavItem. Products decide how to interpret the tree (flat, grouped sidebar, nested menu, etc.)routeact as containers/headers — removed when all children are filtered out by permissionsTest plan